feat: generate charm dellpowervault#743
Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
Open
Conversation
ahmad-can
force-pushed
the
feature/generate-dellpowervault-charm
branch
from
766868e to
85bcca1
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new Sunbeam storage backend implementation for Dell PowerVault, enabling it to be discovered and configured via the existing backend loader.
Changes:
- Introduce
DellpowervaultBackendand its Pydantic config model (DellpowervaultConfig). - Define PowerVault-specific configuration fields (SAN IP, protocol, optional SSL cert, pool, iSCSI target IPs).
- Add a new backend package module for Dell PowerVault.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/dellpowervault/backend.py | Implements the Dell PowerVault backend class and its configuration schema. |
| sunbeam-python/sunbeam/storage/backends/dellpowervault/init.py | Declares the new backend package/module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-dellpowervault-charm
branch
from
f62879e to
21e66ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983552